Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11984 )
Change subject: IMPALA-7853: Add support to read int64 NANO timestamps from Parquet ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11984/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11984/2//COMMIT_MSG@12 PS2, Line 12: 1677-09-21 00:12:43.145224192 .. 2262-04-11 23:47:16.854775807 UTC Maybe you could mention that it stores the number of nanoseconds since the unix epoch. That's why it represents this strange time-range. http://gerrit.cloudera.org:8080/#/c/11984/2/fe/src/main/java/org/apache/impala/analysis/ParquetHelper.java File fe/src/main/java/org/apache/impala/analysis/ParquetHelper.java: http://gerrit.cloudera.org:8080/#/c/11984/2/fe/src/main/java/org/apache/impala/analysis/ParquetHelper.java@248 PS2, Line 248: LogicalTypeAnnotation logicalType = parquetType.getLogicalTypeAnnotation(); What happens when there is no "logical type" in a Parquet file, but only "converted type"? -- To view, visit http://gerrit.cloudera.org:8080/11984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I932396d8646f43c0b9ca4a6359f164c4d8349d8f Gerrit-Change-Number: 11984 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 27 Nov 2018 15:10:59 +0000 Gerrit-HasComments: Yes
