Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 )
Change subject: IMPALA-7902: NumericLiteral fixes, refactoring ...................................................................... Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/12001/2/fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java File fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java: http://gerrit.cloudera.org:8080/#/c/12001/2/fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java@668 PS2, Line 668: paramExprs.add(NumericLiteral.create(window_.getRightBoundary().getOffsetValue(), line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/12001/2/fe/src/test/java/org/apache/impala/analysis/NumericLiteralTest.java File fe/src/test/java/org/apache/impala/analysis/NumericLiteralTest.java: http://gerrit.cloudera.org:8080/#/c/12001/2/fe/src/test/java/org/apache/impala/analysis/NumericLiteralTest.java@247 PS2, Line 247: assertFalse(NumericLiteral.isOverflow(BigDecimal.valueOf(Float.MIN_VALUE), Type.FLOAT)); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/12001/2/fe/src/test/java/org/apache/impala/analysis/NumericLiteralTest.java@259 PS2, Line 259: assertFalse(NumericLiteral.isOverflow(BigDecimal.valueOf(Double.MIN_VALUE), Type.DOUBLE)); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/12001/2/fe/src/test/java/org/apache/impala/analysis/NumericLiteralTest.java@269 PS2, Line 269: assertFalse(NumericLiteral.isOverflow(new BigDecimal(genDecimal(10,5)), Type.DECIMAL)); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/12001/2/fe/src/test/java/org/apache/impala/analysis/NumericLiteralTest.java@270 PS2, Line 270: assertFalse(NumericLiteral.isOverflow(new BigDecimal(genDecimal(10,5)), Type.DECIMAL)); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/12001/2/fe/src/test/java/org/apache/impala/analysis/NumericLiteralTest.java@271 PS2, Line 271: assertFalse(NumericLiteral.isOverflow(new BigDecimal(genDecimal(ScalarType.MAX_PRECISION, 0)), Type.DECIMAL)); line too long (114 > 90) http://gerrit.cloudera.org:8080/#/c/12001/2/fe/src/test/java/org/apache/impala/analysis/NumericLiteralTest.java@272 PS2, Line 272: assertFalse(NumericLiteral.isOverflow(new BigDecimal(genDecimal(0, ScalarType.MAX_PRECISION)), Type.DECIMAL)); line too long (114 > 90) http://gerrit.cloudera.org:8080/#/c/12001/2/fe/src/test/java/org/apache/impala/analysis/NumericLiteralTest.java@273 PS2, Line 273: assertTrue(NumericLiteral.isOverflow(new BigDecimal(genDecimal(ScalarType.MAX_PRECISION + 1, 0)), Type.DECIMAL)); line too long (117 > 90) http://gerrit.cloudera.org:8080/#/c/12001/2/fe/src/test/java/org/apache/impala/analysis/NumericLiteralTest.java@274 PS2, Line 274: assertTrue(NumericLiteral.isOverflow(new BigDecimal(genDecimal(ScalarType.MAX_PRECISION + 1, 1)), Type.DECIMAL)); line too long (117 > 90) http://gerrit.cloudera.org:8080/#/c/12001/2/fe/src/test/java/org/apache/impala/analysis/NumericLiteralTest.java@275 PS2, Line 275: assertTrue(NumericLiteral.isOverflow(new BigDecimal(genDecimal(0, ScalarType.MAX_PRECISION + 1)), Type.DECIMAL)); line too long (117 > 90) http://gerrit.cloudera.org:8080/#/c/12001/2/fe/src/test/java/org/apache/impala/analysis/NumericLiteralTest.java@438 PS2, Line 438: result = NumericLiteral.convertValue(BigDecimal.ZERO, ScalarType.createDecimalType(2, 2)); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/12001/2/fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java File fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java: http://gerrit.cloudera.org:8080/#/c/12001/2/fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java@235 PS2, Line 235: Assert.assertTrue(e.getMessage().contains("Value 11.1 cannot be cast to type DECIMAL(1,0)")); line too long (99 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I484600747b2871d3a6fe9153751973af9a8534f2 Gerrit-Change-Number: 12001 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 29 Nov 2018 08:09:33 +0000 Gerrit-HasComments: Yes
