Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12000 )
Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/12000/3/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/12000/3/be/src/runtime/coordinator-backend-state.cc@571 PS3, Line 571: > Maybe clamp this at 0 to make sure we won't return a negative value if some Done http://gerrit.cloudera.org:8080/#/c/12000/3/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/12000/3/tests/query_test/test_observability.py@83 PS3, Line 83: rt_time_str, '%Y-% > get_thrift_profile takes a timeout, so you can call it once before the loop Done http://gerrit.cloudera.org:8080/#/c/12000/3/tests/query_test/test_observability.py@90 PS3, Line 90: > Can you make this a constant and add a comment. Otherwise this test will fa Iterate through all the nodes in the new PS. http://gerrit.cloudera.org:8080/#/c/12000/3/tests/query_test/test_observability.py@108 PS3, Line 108: assert result.exec_summary[scan_idx]['detail'] == 'functional_kudu.alltypestiny' > I found this part tricky to read. Why is it 8 seconds? Can you elaborate in The test in new PS is simplified to not check for monotonicity of the timestamp as that's not part of the scope. http://gerrit.cloudera.org:8080/#/c/12000/3/tests/query_test/test_observability.py@112 PS3, Line 112: result = self.execute_query(quer > Should we just call close_query() here? Done -- To view, visit http://gerrit.cloudera.org:8080/12000 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae3dcddc292d694d7003d10ed0caccfceed7d8fa Gerrit-Change-Number: 12000 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Balazs Jeszenszky <jes...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Sat, 01 Dec 2018 00:01:23 +0000 Gerrit-HasComments: Yes
