Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12019 )
Change subject: IMPALA-6955: fix test_query_concurrency and server startup sequence ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12019/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/12019/1/be/src/service/impala-server.cc@2202 PS1, Line 2202: http_handler_.reset(new ImpalaHttpHandler(this)); : http_handler_->RegisterHandlers(exec_env_->webserver()); Can you please add a comment that this needs to happen after the ImpalaServer has registered with ExecEnv or it may result in some sort of races ? -- To view, visit http://gerrit.cloudera.org:8080/12019 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If22f71ab6edaf9a6b46afc0985c73dc4625b5103 Gerrit-Change-Number: 12019 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 03 Dec 2018 19:54:59 +0000 Gerrit-HasComments: Yes
