Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10928 )
Change subject: IMPALA-7811: optionally count JVM heap towards process mem limit ...................................................................... Patch Set 14: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/10928/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10928/13//COMMIT_MSG@29 PS13, Line 29: > nit: long line Done http://gerrit.cloudera.org:8080/#/c/10928/13/tests/custom_cluster/test_jvm_mem_tracking.py File tests/custom_cluster/test_jvm_mem_tracking.py: http://gerrit.cloudera.org:8080/#/c/10928/13/tests/custom_cluster/test_jvm_mem_tracking.py@66 PS13, Line 66: * > (feel free to ignore this comment) maybe use 100 * MB here too since thats Done -- To view, visit http://gerrit.cloudera.org:8080/10928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39dd715882a32fc986755d573bd46f0fd9eefbfc Gerrit-Change-Number: 10928 Gerrit-PatchSet: 14 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 04 Dec 2018 03:49:50 +0000 Gerrit-HasComments: Yes
