Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12029 )
Change subject: IMPALA-7473: fix crash when printing decimal with -v=3 ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12029/1/be/src/runtime/decimal-test.cc File be/src/runtime/decimal-test.cc: http://gerrit.cloudera.org:8080/#/c/12029/1/be/src/runtime/decimal-test.cc@723 PS1, Line 723: // PrintValue() contained different generated code that wasn't safe for unaligned values. > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/12029/1/be/src/runtime/decimal-value.inline.h File be/src/runtime/decimal-value.inline.h: http://gerrit.cloudera.org:8080/#/c/12029/1/be/src/runtime/decimal-value.inline.h@687 PS1, Line 687: + (value_ < 0); // Add a space for negative sign > for consistency, should this be value (no underscore) too? Yep that was an oversight -- To view, visit http://gerrit.cloudera.org:8080/12029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I772681b78cda27d6c2086b91151ca8bdcd901828 Gerrit-Change-Number: 12029 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 04 Dec 2018 19:56:33 +0000 Gerrit-HasComments: Yes
