Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12018 )
Change subject: IMPALA-7914: Base interface for statement-like AST nodes ...................................................................... Patch Set 3: (1 comment) Bharath, thanks for the good documentation suggestion; went ahead and made the change. http://gerrit.cloudera.org:8080/#/c/12018/3/fe/src/main/java/org/apache/impala/analysis/StmtNode.java File fe/src/main/java/org/apache/impala/analysis/StmtNode.java: http://gerrit.cloudera.org:8080/#/c/12018/3/fe/src/main/java/org/apache/impala/analysis/StmtNode.java@25 PS3, Line 25: * Parse nodes divide into two broad categories: statement-like nodes (derived : * from this interface) and expression nodes (which derive from Expr.) : * : * Statement-like nodes form the structure of a query and mostly retain their : * structure during analysis. That is, they are "analyzed in place." By contrast, : * expressions are often rewritten so that the final expression out of the analyzer : * may be different than the expression received from the parser. As a result, the : * analyze interface differs between the two categories. : * : * Error reporting often wants to emit the user's original SQL expression before : * rewrites. Statements hold onto both the original and rewritten expressions. : * Expressions, by contrast don't know if they are original or rewritten. > I think this overview makes more sense in the parent ParseNode class? Done -- To view, visit http://gerrit.cloudera.org:8080/12018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie565ff02ad74f805a667017ba9bc8c0a2697a97b Gerrit-Change-Number: 12018 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <par0...@yahoo.com> Gerrit-Comment-Date: Wed, 05 Dec 2018 20:32:07 +0000 Gerrit-HasComments: Yes
