Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11791 )
Change subject: IMPALA-5200: Count child time for parent's total time ...................................................................... Patch Set 2: Code-Review+1 (1 comment) LGTM aside from one minor comment. Not sure if Phil plans to take a look. http://gerrit.cloudera.org:8080/#/c/11791/2/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/11791/2/be/src/util/runtime-profile.cc@427 PS2, Line 427: total_time_ns_ = max(children_total_time, total_time_counter()->value()); Might be worth mentioning this JIRA in a comment here to justify taking the max() -- To view, visit http://gerrit.cloudera.org:8080/11791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6c1191c39fd18b6be45325366a74cf54908c77e Gerrit-Change-Number: 11791 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 06 Dec 2018 18:21:16 +0000 Gerrit-HasComments: Yes
