Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12047 )
Change subject: IMPALA-6591: Fix test_ssl flaky test ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12047/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12047/2//COMMIT_MSG@13 PS2, Line 13: met. In other words, the logic that loops while the number of in-flight can you point to where that logic is? ImpaladService.wait_for_num_in_flight_queries() looks ok to me. http://gerrit.cloudera.org:8080/#/c/12047/2/tests/custom_cluster/test_client_ssl.py File tests/custom_cluster/test_client_ssl.py: http://gerrit.cloudera.org:8080/#/c/12047/2/tests/custom_cluster/test_client_ssl.py@88 PS2, Line 88: p = ImpalaShell(args="--ssl") Can we change the constructor to return only when the shell is ready to accept commands? http://gerrit.cloudera.org:8080/#/c/12047/2/tests/custom_cluster/test_client_ssl.py@93 PS2, Line 93: impalad.wait_for_num_in_flight_queries(1) This method actually returns a boolean on whether it reached the required number of queries. We should assert that it returns true. -- To view, visit http://gerrit.cloudera.org:8080/12047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9805269d8b806aecf5d744c219967649a041d49f Gerrit-Change-Number: 12047 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Thu, 06 Dec 2018 23:40:51 +0000 Gerrit-HasComments: Yes
