Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12018 )
Change subject: IMPALA-7914: Base class for statement-like AST nodes ...................................................................... IMPALA-7914: Base class for statement-like AST nodes In order to integrate expression rewrites into the analysis phase, the expression analyze() operation must be able to replace one expression node with another. Statements, however, are analyzed in place. The two types of parse nodes thus need different analyze() semantics. To prepare for that goal, this patch introduces a new StmtNode class as the base for all statement-like AST nodes. The existing analyze() method moves to StmtNode. While Expr still defines this method for now, the future goal is to change the Expr analyze() semantics. Tests: This is purely a code restructuring, no functional changes. Reran all FE tests. Change-Id: Ie565ff02ad74f805a667017ba9bc8c0a2697a97b Reviewed-on: http://gerrit.cloudera.org:8080/12018 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M fe/src/main/java/org/apache/impala/analysis/Expr.java M fe/src/main/java/org/apache/impala/analysis/FromClause.java M fe/src/main/java/org/apache/impala/analysis/FunctionArgs.java M fe/src/main/java/org/apache/impala/analysis/HdfsCachingOp.java M fe/src/main/java/org/apache/impala/analysis/KuduPartitionParam.java M fe/src/main/java/org/apache/impala/analysis/ParseNode.java M fe/src/main/java/org/apache/impala/analysis/PartitionDef.java M fe/src/main/java/org/apache/impala/analysis/PartitionSpecBase.java M fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java M fe/src/main/java/org/apache/impala/analysis/RangePartition.java M fe/src/main/java/org/apache/impala/analysis/StatementBase.java A fe/src/main/java/org/apache/impala/analysis/StmtNode.java M fe/src/main/java/org/apache/impala/analysis/TableRef.java M fe/src/main/java/org/apache/impala/analysis/TableSampleClause.java M fe/src/main/java/org/apache/impala/analysis/TypeDef.java M fe/src/main/java/org/apache/impala/analysis/WithClause.java M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java 18 files changed, 72 insertions(+), 21 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/12018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie565ff02ad74f805a667017ba9bc8c0a2697a97b Gerrit-Change-Number: 12018 Gerrit-PatchSet: 8 Gerrit-Owner: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <par0...@yahoo.com>