Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 )
Change subject: IMPALA-7694: Add host resource usage metrics to profile ...................................................................... Patch Set 1: (27 comments) http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py File bin/plot_profile_resource_usage.py: http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@25 PS1, Line 25: d flake8: E501 line too long (162 > 90 characters) http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@28 PS1, Line 28: from thrift.protocol import TCompactProtocol flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@29 PS1, Line 29: from thrift.TSerialization import deserialize flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@30 PS1, Line 30: from RuntimeProfile.ttypes import TRuntimeProfileTree flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@32 PS1, Line 32: import argparse flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@33 PS1, Line 33: import base64 flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@34 PS1, Line 34: import datetime flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@35 PS1, Line 35: import sys flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@36 PS1, Line 36: import zlib flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@38 PS1, Line 38: import matplotlib flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@40 PS1, Line 40: import matplotlib.pyplot as plt flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@42 PS1, Line 42: from collections import namedtuple flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@42 PS1, Line 42: from collections import namedtuple flake8: F401 'collections.namedtuple' imported but unused http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@44 PS1, Line 44: class ResourceUsageNotFound(Exception): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@47 PS1, Line 47: class CountersNotFound(Exception): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@50 PS1, Line 50: class CounterNotFound(Exception): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@53 PS1, Line 53: def create_parser(): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@64 PS1, Line 64: def find_resource_usage_nodes(thrift_profile): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@80 PS1, Line 80: def extract_ts_counters(thrift_profile): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@97 PS1, Line 97: def byte_to_percent(values): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@101 PS1, Line 101: def plot_counter_for_all_hosts(per_node_counters, counter_name, output_file): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@129 PS1, Line 129: / flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/12069/1/bin/plot_profile_resource_usage.py@148 PS1, Line 148: flake8: W391 blank line at end of file http://gerrit.cloudera.org:8080/#/c/12069/1/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/12069/1/tests/query_test/test_observability.py@370 PS1, Line 370: ] flake8: E124 closing bracket does not match visual indentation http://gerrit.cloudera.org:8080/#/c/12069/1/tests/query_test/test_observability.py@385 PS1, Line 385: ] flake8: E124 closing bracket does not match visual indentation http://gerrit.cloudera.org:8080/#/c/12069/1/tests/query_test/test_observability.py@414 PS1, Line 414: r flake8: F821 undefined name 'result' http://gerrit.cloudera.org:8080/#/c/12069/1/tests/query_test/test_observability.py@432 PS1, Line 432: n flake8: E713 test for membership should be 'not in' -- To view, visit http://gerrit.cloudera.org:8080/12069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aedc20c553ab8d7ed50f72a1a936eba151487d9 Gerrit-Change-Number: 12069 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 11 Dec 2018 21:08:45 +0000 Gerrit-HasComments: Yes
