Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12069 )

Change subject: IMPALA-7694: Add host resource usage metrics to profile
......................................................................


Patch Set 6:

(11 comments)

http://gerrit.cloudera.org:8080/#/c/12069/6/bin/plot_profile_resource_usage.py
File bin/plot_profile_resource_usage.py:

http://gerrit.cloudera.org:8080/#/c/12069/6/bin/plot_profile_resource_usage.py@25
PS6, Line 25: d
flake8: E501 line too long (162 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/12069/6/bin/plot_profile_resource_usage.py@29
PS6, Line 29: from thrift.protocol import TCompactProtocol
flake8: E402 module level import not at top of file


http://gerrit.cloudera.org:8080/#/c/12069/6/bin/plot_profile_resource_usage.py@30
PS6, Line 30: from thrift.TSerialization import deserialize
flake8: E402 module level import not at top of file


http://gerrit.cloudera.org:8080/#/c/12069/6/bin/plot_profile_resource_usage.py@31
PS6, Line 31: from RuntimeProfile.ttypes import TRuntimeProfileTree
flake8: E402 module level import not at top of file


http://gerrit.cloudera.org:8080/#/c/12069/6/bin/plot_profile_resource_usage.py@33
PS6, Line 33: import argparse
flake8: E402 module level import not at top of file


http://gerrit.cloudera.org:8080/#/c/12069/6/bin/plot_profile_resource_usage.py@34
PS6, Line 34: import base64
flake8: E402 module level import not at top of file


http://gerrit.cloudera.org:8080/#/c/12069/6/bin/plot_profile_resource_usage.py@35
PS6, Line 35: import datetime
flake8: E402 module level import not at top of file


http://gerrit.cloudera.org:8080/#/c/12069/6/bin/plot_profile_resource_usage.py@36
PS6, Line 36: import sys
flake8: E402 module level import not at top of file


http://gerrit.cloudera.org:8080/#/c/12069/6/bin/plot_profile_resource_usage.py@37
PS6, Line 37: import zlib
flake8: E402 module level import not at top of file


http://gerrit.cloudera.org:8080/#/c/12069/6/bin/plot_profile_resource_usage.py@39
PS6, Line 39: import matplotlib
flake8: E402 module level import not at top of file


http://gerrit.cloudera.org:8080/#/c/12069/6/bin/plot_profile_resource_usage.py@41
PS6, Line 41: import matplotlib.pyplot as plt
flake8: E402 module level import not at top of file



--
To view, visit http://gerrit.cloudera.org:8080/12069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3aedc20c553ab8d7ed50f72a1a936eba151487d9
Gerrit-Change-Number: 12069
Gerrit-PatchSet: 6
Gerrit-Owner: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Dec 2018 07:31:33 +0000
Gerrit-HasComments: Yes

Reply via email to