Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12022 )
Change subject: IMPALA-5474: Adding a trivial subquery turns error into warning ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12022/4/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/12022/4/shell/impala_client.py@543 PS4, Line 543: """Returns ERROR message for the last_query_handle. Caller knows that the query has This comment is misleading now, which is worse than no comment - this returns *more* than just the error message - it returns the whole log, which includes the error message and also any warnings. -- To view, visit http://gerrit.cloudera.org:8080/12022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibedb11dd3d50bcdb21d508f7d21691925491946e Gerrit-Change-Number: 12022 Gerrit-PatchSet: 4 Gerrit-Owner: Yongjun Zhang <yjzhan...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Yongjun Zhang <yjzhan...@apache.org> Gerrit-Comment-Date: Thu, 13 Dec 2018 18:18:42 +0000 Gerrit-HasComments: Yes
