Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 )
Change subject: WIP: IMPALA-5843: Use page index in Parquet files to skip pages ...................................................................... Patch Set 1: (2 comments) Did an initial pass over this. I don't understand the details yet but the overall structure seems to make sense http://gerrit.cloudera.org:8080/#/c/12065/1/be/src/exec/parquet/parquet-bool-decoder.cc File be/src/exec/parquet/parquet-bool-decoder.cc: PS1: Might be worth pulling out this code change to a separate patch and adding a unit test. http://gerrit.cloudera.org:8080/#/c/12065/1/be/src/util/bit-stream-utils.h File be/src/util/bit-stream-utils.h: PS1: Might be worth pulling out the rle and dict decoder changes into a separate patch with some backend tests - we could get that reviewed and checked in sooner. -- To view, visit http://gerrit.cloudera.org:8080/12065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cc99f129f2048dbafbe7f5a51d1ea3a5005731a Gerrit-Change-Number: 12065 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 14 Dec 2018 01:07:21 +0000 Gerrit-HasComments: Yes
