Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12082 )
Change subject: IMPALA-7931: fix executor shutdown races ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/12082/7/be/src/service/cancellation-work.h File be/src/service/cancellation-work.h: http://gerrit.cloudera.org:8080/#/c/12082/7/be/src/service/cancellation-work.h@18 PS7, Line 18: #pragma once > Interesting. So, that's the new convention we are gonna use in the future ? There was a discussion on dev@ a while ago and that was the consensus: https://lists.apache.org/thread.html/42d6aa5690c838649486fb0e00421dbe4ce11d9d9cccdfa05219945b@%3Cdev.impala.apache.org%3E -- To view, visit http://gerrit.cloudera.org:8080/12082 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c1a80304cb6695d228aca8314e2231727ab1998 Gerrit-Change-Number: 12082 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 19 Dec 2018 01:13:06 +0000 Gerrit-HasComments: Yes
