Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12108 )
Change subject: IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12108/1/source/gflags/gflags-2.2.0-patches/0002-Add-show_hidden-parameter-in-GetAllFlags-function.patch File source/gflags/gflags-2.2.0-patches/0002-Add-show_hidden-parameter-in-GetAllFlags-function.patch: http://gerrit.cloudera.org:8080/#/c/12108/1/source/gflags/gflags-2.2.0-patches/0002-Add-show_hidden-parameter-in-GetAllFlags-function.patch@63 PS1, Line 63: +TEST(GetAllHiddenFlagsTest, BaseTest) { The change itself looks good to me but from this snippet I cannot figure out how the test works, in particular where test_bool_hidden is set. Can you push the whole tree somewhere so we can look at it? -- To view, visit http://gerrit.cloudera.org:8080/12108 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5b22e4b658759d0fd1a172a85e4e35fa5f5c4b6 Gerrit-Change-Number: 12108 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 19 Dec 2018 01:23:36 +0000 Gerrit-HasComments: Yes
