Philip Zeyliger has posted comments on this change. (
http://gerrit.cloudera.org:8080/12116 )
Change subject: WIP IMPALA-7550 Add documentation to profile counters
......................................................................
Patch Set 1:
It's hard to argue with documenting these.
The other extreme position is just to do it in the Thrift, e.g. the following
diff. In practice we might end up generating the thrift (and the docs).
--- common/thrift/RuntimeProfile.thrift
+++ common/thrift/RuntimeProfile.thrift
@@ -92,6 +92,9 @@ struct TRuntimeProfileNode {
2: required i32 num_children
3: required list<TCounter> counters
+ // documentation...
+ 1000: TCounter bytes_read
+
If I were starting from scratch, I would definitely do this from Thrift. (This
is how we do query options, btw, and I think it's largely fine, though we could
do more code generation to avoid the annoyance.) Given where we are, I think
your approach is probably more incremental, which is good.
--
To view, visit http://gerrit.cloudera.org:8080/12116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaa0a44f0a996f3487566b545d984d562e6e1588
Gerrit-Change-Number: 12116
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Dec 2018 21:24:22 +0000
Gerrit-HasComments: No
