Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11915 )
Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Looks like there is no functional change. The code and methods were just moved around. http://gerrit.cloudera.org:8080/#/c/11915/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/11915/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@923 PS2, Line 923: } nit: newline. -- To view, visit http://gerrit.cloudera.org:8080/11915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f4fe3d3a1ab3170e294714dab066d40d169eff1 Gerrit-Change-Number: 11915 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Rogers <prog...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Comment-Date: Sat, 05 Jan 2019 01:00:57 +0000 Gerrit-HasComments: Yes