Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 )
Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader ...................................................................... Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/11575/16/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/11575/16/tests/query_test/test_scanners.py@819 PS16, Line 819: runtime_profile = str(result.runtime_profile) is this wrapping in str() necessary? http://gerrit.cloudera.org:8080/#/c/11575/16/tests/util/counters.py File tests/util/counters.py: http://gerrit.cloudera.org:8080/#/c/11575/16/tests/util/counters.py@19 PS16, Line 19: class SummaryStatsCounter(object): Is there a way that we use the thrift profile directly instead? By now we are parsing the string profile into a class that resembles TSummaryStatsCounter and will have to be kept in sync. If we want to stick with the text profile, we should have a namedtuple + an is_empty(counter) method where we need it. This would keep things more concise. -- To view, visit http://gerrit.cloudera.org:8080/11575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I322f9b324b6828df28e5caf79529085c43d7c817 Gerrit-Change-Number: 11575 Gerrit-PatchSet: 16 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Wed, 09 Jan 2019 19:09:13 +0000 Gerrit-HasComments: Yes
