Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12139 )

Change subject: Support centos:7 for test-with-docker.
......................................................................


Patch Set 1:

(1 comment)

I just have a small question about ntpd on redhat7. Beyond that, I'm ready to 
+2 this.

http://gerrit.cloudera.org:8080/#/c/12139/1/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/12139/1/bin/bootstrap_system.sh@253
PS1, Line 253: redhat6 sudo service ntpd start || grep docker /proc/1/cgroup
> In a "privileged" container this can actually run, so I didn't take this su
Ignoring the nit, we stop ntpd on redhat7 notindocker. Don't we need to start 
it back up for redhat7 notindocker?



--
To view, visit http://gerrit.cloudera.org:8080/12139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7577949b6eaaa2239bcf0fadf64e1490c2106b08
Gerrit-Change-Number: 12139
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Jan 2019 18:18:20 +0000
Gerrit-HasComments: Yes

Reply via email to