Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12257 )
Change subject: IMPALA-8097: mt_dop for all queries via hidden flag ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/12257/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12257/3//COMMIT_MSG@13 PS3, Line 13: because these are not executable. Would you mind elaborating for latter references ? http://gerrit.cloudera.org:8080/#/c/12257/3/be/src/exec/blocking-join-node.cc File be/src/exec/blocking-join-node.cc: http://gerrit.cloudera.org:8080/#/c/12257/3/be/src/exec/blocking-join-node.cc@206 PS3, Line 206: && state->query_options().mt_dop == 0 Seems better to do this check before trying to acquire the thread token. Otherwise, we would leak the token. http://gerrit.cloudera.org:8080/#/c/12257/3/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/12257/3/be/src/runtime/coordinator.cc@a108 PS3, Line 108: Do you recall what the limitation was ? http://gerrit.cloudera.org:8080/#/c/12257/3/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/12257/3/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@161 PS3, Line 161: * - MT_DOP > 0 is not supported for plans with base table joins or table sinks. : * Throws a NotImplementedException if plan validation fails. Comments need updating -- To view, visit http://gerrit.cloudera.org:8080/12257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72f0b02a005e8bf22fd17b8fb5aabf8c0d9b6b15 Gerrit-Change-Number: 12257 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Fri, 25 Jan 2019 21:55:31 +0000 Gerrit-HasComments: Yes
