Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12262 )
Change subject: IMPALA-7941: part 2/2: use cgroups memory limit ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12262/3/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/12262/3/be/src/runtime/exec-env.cc@357 PS3, Line 357: ot > nit: to Done http://gerrit.cloudera.org:8080/#/c/12262/3/be/src/runtime/exec-env.cc@405 PS3, Line 405: --mem_limit=" : << PrettyPrinter::PrintBytes(*bytes_limit); > this log line can be confusing to mean that the --mem_limit was set to byte I changed it to be a bit more verbose - print the bytes limit and then the literal --mem_limit string in parentheses to explain where it came from. I0125 15:48:19.728356 31957 exec-env.cc:405] Using process memory limit: 7.31 GB (--mem_limit=7848997273) -- To view, visit http://gerrit.cloudera.org:8080/12262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9fb4fb936a46fc194a204391d03c07c8c7fba21 Gerrit-Change-Number: 12262 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 25 Jan 2019 23:49:27 +0000 Gerrit-HasComments: Yes
