Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11158 )
Change subject: IMPALA-7540. Intern most repetitive strings and network addresses in catalog ...................................................................... Patch Set 3: (2 comments) Addressed review comments. Todd, anything else you'd like changed? http://gerrit.cloudera.org:8080/#/c/11158/3/fe/src/main/java/org/apache/impala/catalog/CatalogInterners.java File fe/src/main/java/org/apache/impala/catalog/CatalogInterners.java: http://gerrit.cloudera.org:8080/#/c/11158/3/fe/src/main/java/org/apache/impala/catalog/CatalogInterners.java@22 PS3, Line 22: import org.apache.curator.shaded.com.google.common.base.Preconditions; > Switch to guava jar. Done http://gerrit.cloudera.org:8080/#/c/11158/3/fe/src/main/java/org/apache/impala/catalog/CatalogInterners.java@115 PS3, Line 115: Preconditions.checkNotNull(sd); > I think we should be conservative here (and other places) and do something Done -- To view, visit http://gerrit.cloudera.org:8080/11158 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3121aefa4391bcb1477d9dba0a49440d7000d26 Gerrit-Change-Number: 11158 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Comment-Date: Mon, 28 Jan 2019 21:52:26 +0000 Gerrit-HasComments: Yes
