Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12286 )
Change subject: Add support for Ubuntu 18.04 ...................................................................... Patch Set 2: (1 comment) Thanks for slogging all these fixes. This generally looks good, had one thing that needs to be fixed. http://gerrit.cloudera.org:8080/#/c/12286/2/source/gcc/build.sh File source/gcc/build.sh: http://gerrit.cloudera.org:8080/#/c/12286/2/source/gcc/build.sh@75 PS2, Line 75: PATCH_DIR=${THIS_DIR}/gcc-${PACKAGE_VERSION}-patches Is this to avoid appending -p4 to the gcc version? I can imagine that this avoids a bunch of headaches but it's kinda a hack so it's probably worth leaving a comment. Should also be guarded by if [[ $GCC_VERSION = '4.9.2' ]]; then (There's preliminary support for later gcc versions here that there aren't patches for). -- To view, visit http://gerrit.cloudera.org:8080/12286 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1e63fd41ad293008dec2423a5a361cabadcdb8a Gerrit-Change-Number: 12286 Gerrit-PatchSet: 2 Gerrit-Owner: hector.aco...@cloudera.com <hector.aco...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 29 Jan 2019 11:34:12 +0000 Gerrit-HasComments: Yes
