Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12285 )
Change subject: Initial support for building the toolchain in docker ...................................................................... Patch Set 1: Thanks for tackling this Hector! Pinning the various dependencies would definitely be useful; we have been bitten several times by various packages suddenly getting updated under a seemingly unchanged setup script. To ensure compatibility with the widest possible range of build platforms it would seem useful to pin the OS dependencies at suitable less recent release: probably not all Impala users run the latest and greatest release of their respective platforms at all times. It is not just the OS platform (the FROM clause of the Dockerfiles) that may warrant pinning, the same approach seems useful for the installed components as well, e.g. by pinning repo descriptors to the repos corresponding to the platform version. This could ensure that an older platform would not suddenly be updated with packages from a much more recent release (unless explicitly allowed/requested by a change that can be identified later from the git history). -- To view, visit http://gerrit.cloudera.org:8080/12285 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If42c9bc06a3d303642eb37dea784b61e2a1f5cc6 Gerrit-Change-Number: 12285 Gerrit-PatchSet: 1 Gerrit-Owner: hector.aco...@cloudera.com <hector.aco...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 29 Jan 2019 15:20:44 +0000 Gerrit-HasComments: No
