Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12288 )
Change subject: IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Thanks for the reviews. Addressed Joe's comment, carrying his +2. http://gerrit.cloudera.org:8080/#/c/12288/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12288/1//COMMIT_MSG@9 PS1, Line 9: Running against S3 and erasure coded HDFS causes slight changes in the : observed ExchangeScanRatio and breaks such tests. This change limits : TestObservability::test_global_exchange_counters to HDFS local > Nit: Can you mention the test that you are skipping? Also, one can run this Done -- To view, visit http://gerrit.cloudera.org:8080/12288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6cf58113e092d43f5444120040aa49f90cdb91fb Gerrit-Change-Number: 12288 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Comment-Date: Tue, 29 Jan 2019 18:22:48 +0000 Gerrit-HasComments: Yes
