Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 )
Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/12267/2/be/src/exprs/scalar-expr.cc File be/src/exprs/scalar-expr.cc: http://gerrit.cloudera.org:8080/#/c/12267/2/be/src/exprs/scalar-expr.cc@181 PS2, Line 181: } else if (texpr_node.__isset.cast_expr && !texpr_node.cast_expr.cast_format.empty()) { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/12267/2/tests/query_test/test_cast_with_format.py File tests/query_test/test_cast_with_format.py: http://gerrit.cloudera.org:8080/#/c/12267/2/tests/query_test/test_cast_with_format.py@18 PS2, Line 18: import pytest flake8: F401 'pytest' imported but unused http://gerrit.cloudera.org:8080/#/c/12267/2/tests/query_test/test_cast_with_format.py@23 PS2, Line 23: class TestCastWithFormat(ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/12267/2/tests/query_test/test_cast_with_format.py@33 PS2, Line 33: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/12267/2/tests/query_test/test_cast_with_format.py@81 PS2, Line 81: flake8: W391 blank line at end of file -- To view, visit http://gerrit.cloudera.org:8080/12267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia514aaa9e8f5487d396587d5ed24c7348a492697 Gerrit-Change-Number: 12267 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 30 Jan 2019 17:55:05 +0000 Gerrit-HasComments: Yes
