Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12250 )
Change subject: IMPALA-7934: Switch to java.util.Base64 implementation ...................................................................... IMPALA-7934: Switch to java.util.Base64 implementation It is shown that java.util.Base64 implementation seems to have better performance compared to Apache Commons Codec's Base64 implementation, which can benefit operations, such as incremental stats. This patch switches the implementation of Base64 from Apache Commons Codec to java.util.Base64 implementation. This is the JMH benchmark result comparing java.util.Base64 vs Commons Codec's Base64: Result "base64.Base64Benchmark.javaBase64": 31.149 ±(99.9%) 1.567 ms/op [Average] (min, avg, max) = (27.564, 31.149, 34.675), stdev = 2.091 CI (99.9%): [29.583, 32.716] (assumes normal distribution) Result "base64.Base64Benchmark.codecBase64": 65.921 ±(99.9%) 4.762 ms/op [Average] (min, avg, max) = (58.072, 65.921, 80.470), stdev = 6.357 CI (99.9%): [61.159, 70.683] (assumes normal distribution) Benchmark Mode Cnt Score Error Units Base64Benchmark.javaBase64 avgt 25 31.149 ± 1.567 ms/op Base64Benchmark.codecBase64 avgt 25 65.921 ± 4.762 ms/op Testing: - Ran all FE tests - Created a table with incremental stats without a patch and read it with the patch Change-Id: I2d43d4a4f073a800d963ce4c77f21c9efa8471ac --- M fe/src/main/java/org/apache/impala/catalog/Db.java M fe/src/main/java/org/apache/impala/catalog/PartitionStatsUtil.java M fe/src/main/java/org/apache/impala/util/FunctionUtils.java M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java 4 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/12250/4 -- To view, visit http://gerrit.cloudera.org:8080/12250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2d43d4a4f073a800d963ce4c77f21c9efa8471ac Gerrit-Change-Number: 12250 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
