Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 )
Change subject: IMPALA-5872: Testcase builder for query planner ...................................................................... Patch Set 6: (2 comments) Rebased on the master. The biggest missing piece here is the explain stmt from the source cluster. It will be super helpful to include that in the testcase itself so that we have something to compare against. Plumbing that seemed tricker than expected (without having to do a major refactor). I'll do that as a follow-up patch. http://gerrit.cloudera.org:8080/#/c/12221/6/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/12221/6/common/thrift/Frontend.thrift@914 PS6, Line 914: // TODO: Add the EXPLAIN string from the source cluster on which the testcase was collected. > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/12221/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/12221/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@329 PS6, Line 329: * @param initialHmsCnxnTimeoutSec Time (in seconds) CatalogServiceCatalog will wait to establish an initial > line too long (112 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/12221 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec83eeb2dc5136768b70ed581fb8d3ed0335cb52 Gerrit-Change-Number: 12221 Gerrit-PatchSet: 6 Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Balazs Jeszenszky <jes...@gmail.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Comment-Date: Tue, 05 Feb 2019 02:11:32 +0000 Gerrit-HasComments: Yes
