Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12360 )
Change subject: IMPALA-8103: In Analyzed Query use /* and */ to delimit hints. ...................................................................... Patch Set 2: (3 comments) Thanks for the quick review. http://gerrit.cloudera.org:8080/#/c/12360/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/12360/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@1055 PS1, Line 1055: .append(" "); > change to .append(" ") Done http://gerrit.cloudera.org:8080/#/c/12360/1/fe/src/main/java/org/apache/impala/analysis/TableRef.java File fe/src/main/java/org/apache/impala/analysis/TableRef.java: http://gerrit.cloudera.org:8080/#/c/12360/1/fe/src/main/java/org/apache/impala/analysis/TableRef.java@604 PS1, Line 604: output.append(ToSqlUtils.getPlanHintsSql(options, joinHints_)).append(" "); > change to .append(" ") Done http://gerrit.cloudera.org:8080/#/c/12360/1/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: http://gerrit.cloudera.org:8080/#/c/12360/1/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@540 PS1, Line 540: if (options.showRewritten()) { > Is this really needed? We don't know if the user used the -- or /* */ style The javadoc says "Uses the end-of-line commented plan hint style such that hinted views created by Impala are readable by Hive (parsed as a comment by Hive)". This was added in IMPALA-995. Going into that seems a bit out of scope for this change. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/12360 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7215a4c17508e3408680a1d2bb6c3af355c78c8d Gerrit-Change-Number: 12360 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Comment-Date: Tue, 05 Feb 2019 18:56:58 +0000 Gerrit-HasComments: Yes
