Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12068 )
Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/12068/5/be/src/exprs/is-not-empty-predicate.cc File be/src/exprs/is-not-empty-predicate.cc: http://gerrit.cloudera.org:8080/#/c/12068/5/be/src/exprs/is-not-empty-predicate.cc@49 PS5, Line 49: // Sample IR output (with 3 tuple ids in the vector): > This is the IR for ValidTupleId, not IsNotEmptyPredicate Done http://gerrit.cloudera.org:8080/#/c/12068/5/be/src/exprs/is-not-empty-predicate.cc@57 PS5, Line 57: @_ZN6impala16ValidTupleIdExpr21IsTupleFromRowNonNullEPKNS_8TupleRowEi > Anything we can do to get these calls inlined, eg. adding IR_ALWAYS_INLINE? I am now codegen'ing this http://gerrit.cloudera.org:8080/#/c/12068/5/be/src/exprs/slot-ref.cc File be/src/exprs/slot-ref.cc: http://gerrit.cloudera.org:8080/#/c/12068/5/be/src/exprs/slot-ref.cc@482 PS5, Line 482: GetCollectionValImpl > I'm not sure why this function is necessary, as opposed to just moving GetC I removed the *Impl code http://gerrit.cloudera.org:8080/#/c/12068/5/be/src/exprs/valid-tuple-id.cc File be/src/exprs/valid-tuple-id.cc: http://gerrit.cloudera.org:8080/#/c/12068/5/be/src/exprs/valid-tuple-id.cc@60 PS5, Line 60: // Sample IR output (when child is a SlotRef): > This is the IR for IsNotEmptyPredicate, not ValidTupleIdExpr Done http://gerrit.cloudera.org:8080/#/c/12068/5/be/src/exprs/valid-tuple-id.cc@71 PS5, Line 71: @_ZN6impala19IsNotEmptyPredicate10IsNotEmptyERKN10impala_ > Any way to avoid this function call (eg. IR_ALWAYS_INLINE or building it wi I am now codegen'ing it -- To view, visit http://gerrit.cloudera.org:8080/12068 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb87b9e3b879c278ce8638d97bcb320a7555a6b3 Gerrit-Change-Number: 12068 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Comment-Date: Tue, 05 Feb 2019 20:43:53 +0000 Gerrit-HasComments: Yes
