Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12317 )
Change subject: IMPALA-8148: Misc. FE code cleanup ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/12317/5/fe/src/main/java/org/apache/impala/analysis/ColumnDef.java File fe/src/main/java/org/apache/impala/analysis/ColumnDef.java: http://gerrit.cloudera.org:8080/#/c/12317/5/fe/src/main/java/org/apache/impala/analysis/ColumnDef.java@260 PS5, Line 260: if (Expr.IS_NULL_VALUE.apply(defaultValLiteral) && ((isNullable_ != null && !isNullable_) line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/12317/5/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: http://gerrit.cloudera.org:8080/#/c/12317/5/fe/src/main/java/org/apache/impala/analysis/Expr.java@210 PS5, Line 210: public static final com.google.common.base.Predicate<Expr> IS_EXPR_EQ_LITERAL_PREDICATE = line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12317 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e2f2e79f36e804fd592b6fe77f0554c5ca803eb Gerrit-Change-Number: 12317 Gerrit-PatchSet: 5 Gerrit-Owner: Paul Rogers <prog...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Comment-Date: Tue, 05 Feb 2019 22:48:37 +0000 Gerrit-HasComments: Yes
