Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12328 )
Change subject: IMPALA-8096: Add rows returned limit per query ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/12328/3/be/src/exec/plan-root-sink.h File be/src/exec/plan-root-sink.h: http://gerrit.cloudera.org:8080/#/c/12328/3/be/src/exec/plan-root-sink.h@122 PS3, Line 122: total number of rows returned to the client. nit: update comment http://gerrit.cloudera.org:8080/#/c/12328/3/be/src/exec/plan-root-sink.h@127 PS3, Line 127: int use int64_t instead since we allow that range for the query option. same for num_rows_returned_ http://gerrit.cloudera.org:8080/#/c/12328/1/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/12328/1/common/thrift/ImpalaService.thrift@357 PS1, Line 357: // traced, 1 means all queries will be traced. > Done nit: how about NUM_ROWS_PRODUCED_LIMIT? At first glance, ROWS_RETURNED sounds like the num of rows returned by impala (fetched by client) http://gerrit.cloudera.org:8080/#/c/12328/3/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/12328/3/common/thrift/ImpalaService.thrift@372 PS3, Line 372: This : // is a limit on the number of rows produced by query execution. nit: can be replace the first line. http://gerrit.cloudera.org:8080/#/c/12328/3/testdata/workloads/functional-query/queries/QueryTest/query-resource-limits.test File testdata/workloads/functional-query/queries/QueryTest/query-resource-limits.test: http://gerrit.cloudera.org:8080/#/c/12328/3/testdata/workloads/functional-query/queries/QueryTest/query-resource-limits.test@61 PS3, Line 61: show nit:should -- To view, visit http://gerrit.cloudera.org:8080/12328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b22dbe130a368f4be1f3662a559eb9aae7f0c1d Gerrit-Change-Number: 12328 Gerrit-PatchSet: 3 Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 06 Feb 2019 23:17:55 +0000 Gerrit-HasComments: Yes
