Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12124 )
Change subject: IMPALA-8071: Initial unified backend test framework ...................................................................... Patch Set 4: (3 comments) Fix some flake8 issues http://gerrit.cloudera.org:8080/#/c/12124/4/bin/validate-unified-backend-test-filters.py File bin/validate-unified-backend-test-filters.py: http://gerrit.cloudera.org:8080/#/c/12124/4/bin/validate-unified-backend-test-filters.py@24 PS4, Line 24: def get_set_of_tests(unified_binary, filters): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/12124/4/bin/validate-unified-backend-test-filters.py@44 PS4, Line 44: def main(): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/12124/4/bin/validate-unified-backend-test-filters.py@64 PS4, Line 64: if __name__ == "__main__": main() > flake8: E305 expected 2 blank lines after class or function definition, fou Done -- To view, visit http://gerrit.cloudera.org:8080/12124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia03ef38719b1fbc0fe2025e16b7b3d3dd4488842 Gerrit-Change-Number: 12124 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 07 Feb 2019 01:10:17 +0000 Gerrit-HasComments: Yes
