Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 )
Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. ...................................................................... Patch Set 7: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/12260/6/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/12260/6/be/src/service/client-request-state.cc@695 PS6, Line 695: This may be because the port specified is a thrift port, which" : " :shutdown() can no longer use. > I'm not sure what you mean here. Yes we can't be sure that the reason we ca "Using thrift port" is a subset of "using the wrong port". The case of "using thrift port" is true iff port == FLAGS_be_port which apparently isn't part of the if-stmt here so it's not precise to say so in the error message. Anyhow, it's just a minor point so it's not worth dwelling on it. Please feel free to ignore the suggestion. http://gerrit.cloudera.org:8080/#/c/12260/7/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/12260/7/be/src/service/client-request-state.cc@691 PS7, Line 691: request.__isset.backend && request.backend.port nit: factor this out common expression as it's used on line 639 above -- To view, visit http://gerrit.cloudera.org:8080/12260 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fd00ee4e638f5e71e27893162fd65501ef9e74e Gerrit-Change-Number: 12260 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Comment-Date: Thu, 07 Feb 2019 02:35:15 +0000 Gerrit-HasComments: Yes
