Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 )
Change subject: IMPALA-8095: Detailed expression cardinality tests ...................................................................... Patch Set 7: (1 comment) Lgtm, just one pending clarification. http://gerrit.cloudera.org:8080/#/c/12248/7/fe/src/test/java/org/apache/impala/analysis/ExprCardinalityTest.java File fe/src/test/java/org/apache/impala/analysis/ExprCardinalityTest.java: http://gerrit.cloudera.org:8080/#/c/12248/7/fe/src/test/java/org/apache/impala/analysis/ExprCardinalityTest.java@122 PS7, Line 122: // Bug: NDV of partition columns is -1 though it is listed as : // 2 in the shell with: SHOW COLUMN STATS alltypes : //verifyTableCol(allTypes, "year", 2, 0); : // Bug: When tests are run in Eclipse we get the result above. : // But, when the same test is run using maven from the command line, : // we get the result shown below. : // Unit test in Eclipse see the above, unit tests run from the : // Disabling both to avoid a flaky test, : // Same issue for the next three tests. : //verifyTableCol(allTypes, "year", -1, -1); : //verifyTableCol(allTypes, "month", 12, 0); : //verifyTableCol(allTypes, "month", -1, -1); (This and multiple places below) Should we dig into this further? Wondering if there is any value in keeping "eclipse" specific references. Maybe just include mvn results since that is what is verified in the unittests? Also since that is consistently happening only with partition columns, I'm curious if there is any hidden bug somewhere. -- To view, visit http://gerrit.cloudera.org:8080/12248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3da58ee9b0beebeffb170b9430bd36d20dcd2401 Gerrit-Change-Number: 12248 Gerrit-PatchSet: 7 Gerrit-Owner: Paul Rogers <prog...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 07 Feb 2019 06:29:20 +0000 Gerrit-HasComments: Yes
