Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12124 )
Change subject: IMPALA-8071: Initial unified backend test framework ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/12124/7/be/src/service/unified-betest-main.cc File be/src/service/unified-betest-main.cc: http://gerrit.cloudera.org:8080/#/c/12124/7/be/src/service/unified-betest-main.cc@36 PS7, Line 36: = > space around parens Done http://gerrit.cloudera.org:8080/#/c/12124/7/be/src/util/CMakeLists.txt File be/src/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/12124/7/be/src/util/CMakeLists.txt@182 PS7, Line 182: # redactor-test and redactor-unconfigured-test both use redactor-test-util.h, which > Pretty sure we just need to mark those functions in the header as inline to Moved the functions into redactor-test-utils.cc and fixed this up to be unified. -- To view, visit http://gerrit.cloudera.org:8080/12124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia03ef38719b1fbc0fe2025e16b7b3d3dd4488842 Gerrit-Change-Number: 12124 Gerrit-PatchSet: 7 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 08 Feb 2019 01:22:25 +0000 Gerrit-HasComments: Yes
