Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12413 )
Change subject: IMPALA-8163: Add banner showing for local catalog mode when enabled. ...................................................................... Patch Set 5: (4 comments) A bunch of nits, otherwise lgtm. http://gerrit.cloudera.org:8080/#/c/12413/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12413/5//COMMIT_MSG@7 PS5, Line 7: showing for rephrase? http://gerrit.cloudera.org:8080/#/c/12413/5//COMMIT_MSG@9 PS5, Line 9: impalad coordinator? http://gerrit.cloudera.org:8080/#/c/12413/5//COMMIT_MSG@14 PS5, Line 14: V2 local catalog... http://gerrit.cloudera.org:8080/#/c/12413/5/tests/custom_cluster/test_local_catalog.py File tests/custom_cluster/test_local_catalog.py: http://gerrit.cloudera.org:8080/#/c/12413/5/tests/custom_cluster/test_local_catalog.py@332 PS5, Line 332: # Test 'Local Catalog' Banner appears on root page : impalad = self.cluster.impalads[0] : assert '(Local Catalog Mode)' in impalad.service.read_debug_webpage('/') Move this inside test_cache_metrics? Typically custom cluster tests are expensive (since that requires restarting the cluster) and I don't think this specific test requires it's own cluster. -- To view, visit http://gerrit.cloudera.org:8080/12413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaeb2c7b20742a2630d9509da9b629d5f45c55207 Gerrit-Change-Number: 12413 Gerrit-PatchSet: 5 Gerrit-Owner: Anurag Mantripragada <anuragmantr...@gmail.com> Gerrit-Reviewer: Anurag Mantripragada <anuragmantr...@gmail.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Sat, 09 Feb 2019 01:38:21 +0000 Gerrit-HasComments: Yes
