Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12401 )
Change subject: IMPALA-8064: Improve observability of wait times for runtime filters ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12401/2/be/src/exec/scan-node.cc File be/src/exec/scan-node.cc: http://gerrit.cloudera.org:8080/#/c/12401/2/be/src/exec/scan-node.cc@172 PS2, Line 172: 32 int64 here and for 'end'. int32 will work for wait_time_ms() since delay is a difference between 2 time values, but start and end store the absolute result from MonotonicMillis() which is usually the time since system start and can be a larger number than what int32 can store http://gerrit.cloudera.org:8080/#/c/12401/2/be/src/exec/scan-node.cc@191 PS2, Line 191: Maximum runtime filter wait time reading it now, this might sound like its just printing out the max_runtime_filter_wait_time query option instead the actual wait time since it can be equal to the query option in some cases where the filters dont arrive on time. Unfortunately, i dont really have a better suggestion without being verbose. -- To view, visit http://gerrit.cloudera.org:8080/12401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28fd45e75c773bc01d424f5a179ae186ee9b7469 Gerrit-Change-Number: 12401 Gerrit-PatchSet: 2 Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Comment-Date: Mon, 11 Feb 2019 21:50:21 +0000 Gerrit-HasComments: Yes
