Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12247 )
Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet ...................................................................... Patch Set 8: (1 comment) About the last 3 patch sets: patch set 6 changes nanos->millis/micros conversions to round towards minus infinity instead of the nearest integer patch set 7 fixes a comment by Zoltan Borok-Nagy and a copy-paste error in patch 6 patch set 8 is a rebase + conflict resolution. Rebasing was necessary because of Impala-lzo changes broke the build. About checking the written Parquet files with Parquet tool: thanks for the tool - I used it to check the written files manually, but I would prefer to integrate it into Impala in a separate commit. A jira to track this: IMPALA-8197 http://gerrit.cloudera.org:8080/#/c/12247/3/be/src/exec/parquet/hdfs-parquet-table-writer.cc File be/src/exec/parquet/hdfs-parquet-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/12247/3/be/src/exec/parquet/hdfs-parquet-table-writer.cc@583 PS3, Line 583: successful and return true. If the timestamp is invalid > It seemed premature optimization to me, so I did some measurements and look Done -- To view, visit http://gerrit.cloudera.org:8080/12247 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib41ad532ec902ed5a9a1528513726eac1c11441f Gerrit-Change-Number: 12247 Gerrit-PatchSet: 8 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Zoltan Ivanfi <zi+ger...@cloudera.com> Gerrit-Comment-Date: Wed, 13 Feb 2019 19:18:34 +0000 Gerrit-HasComments: Yes
