Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 )
Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla ...................................................................... Patch Set 2: (1 comment) We need to bump impyla_version in infra/python/deps/compiled-requirements.txt, right? Otherwise looks good. http://gerrit.cloudera.org:8080/#/c/12530/2/tests/query_test/test_cancellation.py File tests/query_test/test_cancellation.py: http://gerrit.cloudera.org:8080/#/c/12530/2/tests/query_test/test_cancellation.py@223 PS2, Line 223: assert any(client.get_state(handle) == 'RUNNING_STATE' or sleep(1) This is cool -- To view, visit http://gerrit.cloudera.org:8080/12530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I769a99f0843297dd2b20f2f5b1a9046c97bb131e Gerrit-Change-Number: 12530 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 20 Feb 2019 05:02:41 +0000 Gerrit-HasComments: Yes