Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12438 )
Change subject: IMPALA-8181: Abbreviate row counts in EXPLAIN ...................................................................... Patch Set 6: Code-Review+2 (2 comments) Feel free to carry +2 after the test run finishes. http://gerrit.cloudera.org:8080/#/c/12438/5/fe/src/main/java/org/apache/impala/common/PrintUtils.java File fe/src/main/java/org/apache/impala/common/PrintUtils.java: http://gerrit.cloudera.org:8080/#/c/12438/5/fe/src/main/java/org/apache/impala/common/PrintUtils.java@66 PS5, Line 66: if (value >= GIGA) return new DecimalFormat(".00G").format(result / GIGA); > Created an "exact cardinality" method to format the values as suggested. Th Thanks http://gerrit.cloudera.org:8080/#/c/12438/6/fe/src/main/java/org/apache/impala/common/PrintUtils.java File fe/src/main/java/org/apache/impala/common/PrintUtils.java: http://gerrit.cloudera.org:8080/#/c/12438/6/fe/src/main/java/org/apache/impala/common/PrintUtils.java@156 PS6, Line 156: , this is cool, didn't know about this grouping separator. -- To view, visit http://gerrit.cloudera.org:8080/12438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08faaa9ad7b5ed42dcd7a15a333e8734bb45f10c Gerrit-Change-Number: 12438 Gerrit-PatchSet: 6 Gerrit-Owner: Paul Rogers <prog...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Comment-Date: Wed, 20 Feb 2019 07:12:18 +0000 Gerrit-HasComments: Yes
