Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12301 )
Change subject: Logging current database context when logging analyzing queries. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12301/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/12301/1/fe/src/main/java/org/apache/impala/service/Frontend.java@1243 PS1, Line 1243: + queryCtx.session.database); > In Java, a general rule is to use accessor methods, but since this is Thrif I'm not using accessor methods because that was the local style. It's a little selfish, but if the query doesn't have newlines in it (as many queries don't), then you get one query per log line, which is super handy for grep. I can certainly move the db up, like: Analyzing query (default db: ...): .... if you think that looks better. -- To view, visit http://gerrit.cloudera.org:8080/12301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70886be4685e0d3ae7ca9f6e57e8159dc39c67c7 Gerrit-Change-Number: 12301 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Wed, 20 Feb 2019 19:21:54 +0000 Gerrit-HasComments: Yes