Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12544 )
Change subject: IMPALA-8235: avoid TIME_MS in runtime profile ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12544/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12544/1//COMMIT_MSG@10 PS1, Line 10: areare > are Done http://gerrit.cloudera.org:8080/#/c/12544/1//COMMIT_MSG@13 PS1, Line 13: Work around the issue by using the older TIME_NS type for this : counter. > What's the plan going forward ? Do we need to identify a set of interfaces Lars is documenting this a bit better here: https://gerrit.cloudera.org/#/c/12543/ I'm not sure what to do about evolution of TUnit going forward - thrift doesn't really seem to support evolution of required enums very well. IMPALA-8236 tracks that issue. http://gerrit.cloudera.org:8080/#/c/12544/1/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/12544/1/be/src/scheduling/admission-controller.cc@1108 PS1, Line 1108: static_cast<int64_t>( > Why is this cast necessary ? Isn't time_since_update_ms already int64_t ? NANOS_PER_MICRO and MICROS_PER_MILLI are a "long long" and the compiler can't figure out whether to use the Set(int) or Set(int64_t) overload because int64_t is a typedef of long and it considers long and "long long" to be different types. -- To view, visit http://gerrit.cloudera.org:8080/12544 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia6a0846f401ced1947187b8581563de9dbb4fe53 Gerrit-Change-Number: 12544 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 21 Feb 2019 02:04:10 +0000 Gerrit-HasComments: Yes
