Bikramjeet Vig has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12550 )

Change subject: [DOCS] Updated the description of the port_number parameter in 
SHUTDOWN
......................................................................


Patch Set 1:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml
File docs/topics/impala_shutdown.xml:

http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@90
PS1, Line 90: current <codeph>impalad
should we be more specific to clarify that the "current impalad" is the impalad 
to whom the shutdown statement is submitted.


http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@95
PS1, Line 95: backend
nit: impalad
To be consistent on how we address impalad/backend


http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@116
PS1, Line 116: the same backend port as the current
the current impalad's port on which the thrift based ImpalaInternalService is 
exported


http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@117
PS1, Line 117: 25000
22000


http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@121
PS1, Line 121: the KRPC port for the current
the current impalad's port on which the KRPC based ImpalaInternalService is 
exported


http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@131
PS1, Line 131: use the same <codeph>impalad</codeph> port.
use the port on the impalad to be shut down on which the thrift based 
ImpalaInternalService is exported


http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@135
PS1, Line 135: use the KRPC port for your <codeph>impalad</codeph>.
use the port on the impalad to be shut down on which the KRPC based 
ImpalaInternalService is exported


http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@181
PS1, Line 181: another non-coordinator <codeph>impalad
any impalad


http://gerrit.cloudera.org:8080/#/c/12550/1/docs/topics/impala_shutdown.xml@194
PS1, Line 194: threshold time limit
nit: maybe use the same term 'grace period' here to be consistent with the 
first para.



--
To view, visit http://gerrit.cloudera.org:8080/12550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b1e3e228059860b764885395c88cecd3033ff41
Gerrit-Change-Number: 12550
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <arod...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 21:47:15 +0000
Gerrit-HasComments: Yes

Reply via email to