Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12549 )
Change subject: IMPALA-7975 : Improve supportability of the automatic invalidate feature ...................................................................... Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/12549/4/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/12549/4/be/src/catalog/catalog-server.cc@528 PS4, Line 528: document->AddMember("event_processor_metrics", event_processor_summary, document->GetAllocator()); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/12549/4/be/src/catalog/catalog.h File be/src/catalog/catalog.h: http://gerrit.cloudera.org:8080/#/c/12549/4/be/src/catalog/catalog.h@111 PS4, Line 111: /// Returns the metastore event processor summary view. The summary string in the response line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/12549/4/be/src/catalog/catalog.cc File be/src/catalog/catalog.cc: http://gerrit.cloudera.org:8080/#/c/12549/4/be/src/catalog/catalog.cc@163 PS4, Line 163: Status Catalog::GetEventProcessorSummary(TGetEventProcessorMetricsSummaryResponse* response) { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/12549/4/be/src/util/event-metrics.h File be/src/util/event-metrics.h: http://gerrit.cloudera.org:8080/#/c/12549/4/be/src/util/event-metrics.h@28 PS4, Line 28: /// refresh all the metrics which are used to display on webui based on the given response line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/12549/4/be/src/util/event-metrics.h@29 PS4, Line 29: /// this method should be called at regular intervals to update the metrics information on line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/12549/4/be/src/util/event-metrics.cc File be/src/util/event-metrics.cc: http://gerrit.cloudera.org:8080/#/c/12549/4/be/src/util/event-metrics.cc@56 PS4, Line 56: EVENT_PROCESSOR_STATUS = event_metrics->AddProperty<string>(EVENT_PROCESSOR_STATUS_METRIC_NAME, "Unavailable"); line too long (113 > 90) http://gerrit.cloudera.org:8080/#/c/12549/4/be/src/util/event-metrics.cc@79 PS4, Line 79: LOG(ERROR) << "Received a null response when trying to refresh metastore event metrics"; line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/12549/4/common/thrift/JniCatalog.thrift File common/thrift/JniCatalog.thrift: http://gerrit.cloudera.org:8080/#/c/12549/4/common/thrift/JniCatalog.thrift@791 PS4, Line 791: // summary view of the events processor which can include status, metrics and other details line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12549 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23cb3aa866879eca03c64ab881796eaa9caa0337 Gerrit-Change-Number: 12549 Gerrit-PatchSet: 4 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Mon, 25 Feb 2019 23:17:03 +0000 Gerrit-HasComments: Yes
