Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12559 )
Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala ...................................................................... Patch Set 2: > The changes look good to me, but I have some doubts about this > information's relevance for users - understanding the difference > between physical type / original type (=converted type) / logical > type needs some knowledge about Parquet and its history. It would > help a lot to have a table with Hadoop components / versions and > the type of timestamp they write in Parquet, and the problems we > can expect when reading these with Impala. > > I have added Zoltan Ivanfi as reviewer. I know! It took me a while to read up and understand the previous notation for logical types. Let me know what else I can add to make it easier to understand. Meanwhile, your idea about a new table with timestamp is excellent. > The changes look good to me, but I have some doubts about this > information's relevance for users - understanding the difference > between physical type / original type (=converted type) / logical > type needs some knowledge about Parquet and its history. It would > help a lot to have a table with Hadoop components / versions and > the type of timestamp they write in Parquet, and the problems we > can expect when reading these with Impala. > > I have added Zoltan Ivanfi as reviewer. I totally agree. It took me a while to read up and understand the original notation for the logical types. Let me know what else we can add to make it easier to understand. Your idea about a new table with various components and timestamps is excellent. If you have that information readily available, I can use it. Otherwise, I will create a separate ticket to for that task after the release. -- To view, visit http://gerrit.cloudera.org:8080/12559 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654 Gerrit-Change-Number: 12559 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Zoltan Ivanfi <zi+ger...@cloudera.com> Gerrit-Comment-Date: Mon, 25 Feb 2019 23:53:37 +0000 Gerrit-HasComments: No
