Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12581 )
Change subject: IMPALA-4784: Remove InProcessStatestore ...................................................................... Patch Set 1: This is the next pick after https://jenkins.impala.io/job/cherrypick-2.x-and-test/653/ finish. This patch has some conflicts: both modified: be/src/exprs/expr-test.cc both modified: be/src/statestore/statestore-test.cc both modified: be/src/testutil/in-process-servers.cc It's based on a privious patch that's ignored for branch 2.x: https://gerrit.cloudera.org/c/10740/ We ignored it since it depends on thrift-0.9.2+. We haven't upgraded thrift to 0.9.3 in branch 2.x yet. However, the current patch helps to reduce the complexity of the codes. So I think we should pick it. To resolve the conflicts, we still need to use FindUnusedEphemeralPort() in Statestore::Init(int32_t) if the given port is 0. Some tests still use FindUnusedEphemeralPort() too. -- To view, visit http://gerrit.cloudera.org:8080/12581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I2621873e593b36c9612a6402ac6c5d8e3b49cde9 Gerrit-Change-Number: 12581 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sailesh Mukil <sail...@apache.org> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 25 Feb 2019 23:56:28 +0000 Gerrit-HasComments: No
