Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12583 )
Change subject: IMPALA-5397: Set query's end_time_us_ when the operation completes ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12583/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12583/1//COMMIT_MSG@13 PS1, Line 13: admission control resources i wonder if now we should get rid of the "admission control resources released" timer http://gerrit.cloudera.org:8080/#/c/12583/1//COMMIT_MSG@18 PS1, Line 18: Tested queries with various settings of --idle-query-timeout. : Ran exhaustive end-to-end tests and the stress test without : any failures. can you add a test to test_observability which runs a small query, fetches the results but keeps it open by not closing the query handle, then check if the profile contains end_time http://gerrit.cloudera.org:8080/#/c/12583/1/be/src/runtime/coordinator.h File be/src/runtime/coordinator.h: http://gerrit.cloudera.org:8080/#/c/12583/1/be/src/runtime/coordinator.h@225 PS1, Line 225: client_request_state_ nit: how about parent_request_state_ ? -- To view, visit http://gerrit.cloudera.org:8080/12583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa9a1b443df3dbd95f9f297c2f923ad795b14745 Gerrit-Change-Number: 12583 Gerrit-PatchSet: 1 Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 26 Feb 2019 19:04:25 +0000 Gerrit-HasComments: Yes
