Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12616
to look at the new patch set (#4).
Change subject: IMPALA-8252: Only write node_metadata if it's set
......................................................................
IMPALA-8252: Only write node_metadata if it's set
Since IMPALA-1048 we write TRuntimeProfileNode.node_metadata
unconditionally, even when both its fields are unset. This trips up the
Thrift library Java reader code, which expects to find exactly one type
of a union to be set.
This change fixes the issue by checking whether at least one of the
fields is set before marking node_metadata as set.
This change also adds a test to runtime-profile-test.cc to make sure
that the __isset flag is set correctly. Additionally I wrote a profile
and then manually read it with a Java client.
Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
---
M be/src/util/CMakeLists.txt
M be/src/util/runtime-profile-test.cc
M be/src/util/runtime-profile.cc
3 files changed, 23 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/12616/4
--
To view, visit http://gerrit.cloudera.org:8080/12616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ice1efcf75daba5c023566eb63d4e921c228c26fd
Gerrit-Change-Number: 12616
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
